Add snake case signatures for workflow binding methods #5398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #5398 will not alter performanceComparing Summary
Footnotes
|
dom96
reviewed
Oct 23, 2025
anonrig
reviewed
Oct 24, 2025
Caio-Nogueira
force-pushed
the
caio/python-snake-case-signatures
branch
from
be89f99 to
5ef66bb
Compare
LuisDuarte1
approved these changes
Oct 24, 2025
Caio-Nogueira
force-pushed
the
caio/python-snake-case-signatures
branch
from
5ef66bb to
1b5be7f
Compare
hoodmane
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python Workflows call into the workflows wrapped binding via FFI. Since the binding is a Js proxy, method signatures from binding object are not automatically converted into snake case (as opposed to other JS methods that get converted by Pyodide).
This PR fixes this problem by adding new methods with snake cased signatures.
The alternative to this would be converting methods in runtime, via the Python entrypoint helper. However, that's not really feasible because we don't have a way to distinguish the workflow wrapper from another userland object.